vsk added a comment.

Hm, this patch is bugging me.

It looks a bit like instructions are still decoded multiple times in different 
ways (e.g. in the `Decode` and `CalculateMnemonicOperandsAndComment` methods, 
which both modify `m_opcode`). Any ideas on whether/how to consolidate these?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69210/new/

https://reviews.llvm.org/D69210



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to