JosephTremoulet marked an inline comment as done. JosephTremoulet added inline comments.
================ Comment at: llvm/test/tools/yaml2obj/minidump-exception-missing-parameter.yaml:3 + +# Test that we report an error for an ExceptionStream where the specified +# number of parameters is greater than the number of ExceptionInformation ---------------- grimar wrote: > nit: It is became common to use ## for comments in yaml2obj and actually many > other LLVM tools test cases. > (here and below) Sorry, when you say "here and below", do you just mean lines 3 and 4-5, or do you also mean the CHECK line (line 20)? Grepping in test/tools it appears to be very uncommon to use ## for CHECK lines, but that's what I'd have otherwise assumed "and below" referred to... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68657/new/ https://reviews.llvm.org/D68657 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
