grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.
LGTM with 2 nits.
================
Comment at: llvm/test/tools/yaml2obj/minidump-exception-missing-parameter.yaml:3
+
+# Test that we report an error for an ExceptionStream where the specified
+# number of parameters is greater than the number of ExceptionInformation
----------------
nit: It is became common to use ## for comments in yaml2obj and actually many
other LLVM tools test cases.
(here and below)
================
Comment at: llvm/unittests/ObjectYAML/MinidumpYAMLTest.cpp:143
+
+// Test that we can parse a normal-looking ExceptionStream
+TEST(MinidumpYAML, ExceptionStream) {
----------------
nit: Missing a full stop (here and below).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68657/new/
https://reviews.llvm.org/D68657
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
