JDevlieghere added inline comments.
================
Comment at: lldb/include/lldb/Target/ThreadPlanPython.h:35
+ ThreadPlanPython(Thread &thread, const char *class_name,
+ StructuredDataImpl *args_data);
~ThreadPlanPython() override;
----------------
Why do we need the StructuredDataImpl and not the StructuredData?
================
Comment at: lldb/source/API/SBThread.cpp:985
bool resume_immediately) {
LLDB_RECORD_METHOD(lldb::SBError, SBThread, StepUsingScriptedThreadPlan,
+ (const char *, lldb::SBStructuredData &, bool),
----------------
It appears this is missing a corresponding LLDB_REGISTER macro.
================
Comment at: lldb/source/API/SBThreadPlan.cpp:78
+ lldb::SBStructuredData &args_data) {
+ LLDB_RECORD_CONSTRUCTOR(SBThreadPlan, (lldb::SBThread &, const char *,
+ SBStructuredData &),
----------------
Same here
================
Comment at: lldb/source/API/SBThreadPlan.cpp:404
+ SBError &error) {
+ LLDB_RECORD_METHOD(lldb::SBThreadPlan, SBThreadPlan,
+ QueueThreadPlanForStepScripted,
----------------
This one is fine it seems.
================
Comment at: lldb/source/API/SBThreadPlan.cpp:409
+
+ if (m_opaque_sp) {
+ Status plan_status;
----------------
Swap this and have an early return?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68366/new/
https://reviews.llvm.org/D68366
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
