vsk added a subscriber: labath.
vsk added a comment.
Great find. The changes in this patch makes sense to me locally, but I'm having
trouble picking up on the context necessary to confidently 'lgtm'. +
@JDevlieghere & @labath to get some more experienced people.
I'd love to see the big switch in ParseTypeFromDWARF broken up into small,
well-commented functions bit-by-bit -- when that's done, I think I'll have a
much better chance at reviewing changes. If folks agree that that's a
reasonable refactor, I'd be happy to send a few patches (perhaps starting with
the DW_TAG_subroutine_type handling).
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1401
type_handled = cxx_method_decl != NULL;
+ // Artificial methods are always handled even when don't
+ // create a new declaration for them.
----------------
nit: we don't ?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68130/new/
https://reviews.llvm.org/D68130
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
