JDevlieghere added inline comments.
================
Comment at: lldb/include/lldb/Utility/Scalar.h:107
+ /// Return the most efficient Scalar::Type for the requested size.
+ static Type GetBestType(size_t bit_size, bool sign);
+
----------------
How about `GetTypeForBitSize`?
================
Comment at: lldb/source/Expression/DWARFExpression.cpp:2571
+ if (stack.size() < 1) {
+ if (error_ptr)
+ error_ptr->SetErrorString(
----------------
Can we wrap this in a lambda?
================
Comment at: lldb/source/Utility/Scalar.cpp:442
+ default:
+ assert(false && "Promoting a Scalar to a specific number of bits is only "
+ "supported for integer types.");
----------------
llvm::unreachable?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67369/new/
https://reviews.llvm.org/D67369
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
