jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land.
LGTM, nice job with the test case, I see myself copying that in the future. :) ================ Comment at: lldb/source/Utility/Scalar.cpp:423 + if (bit_size <= sizeof(int)*8) return Scalar::e_sint; + if (bit_size <= sizeof(long)*8) return Scalar::e_slong; + if (bit_size <= sizeof(long long)*8) return Scalar::e_slonglong; ---------------- What about an ILP32 target like arm64_32, with lldb running on an LP64 system - are we mixing target & host type sizes here? I'm not sure if Scalar's types (e_slong etc) are in host or target terms. I mean this code might as well be if bit_size <= 32 return Scalar::e_Signed32BitType, but I wanted to check in because we're using host type sizes here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67369/new/ https://reviews.llvm.org/D67369 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
