mgorny added a comment. In D63545#1551681 <https://reviews.llvm.org/D63545#1551681>, @labath wrote:
> In D63545#1551675 <https://reviews.llvm.org/D63545#1551675>, @mgorny wrote: > > > In D63545#1551627 <https://reviews.llvm.org/D63545#1551627>, @labath wrote: > > > > > We have the same XSTATE<->YMM conversion functions in NativeProcessLinux. > > > It would be nice to extract them to some common place > > > (Plugins/Process/Utility, I guess :P). > > > > > > Hmm, I guess that's doable if we pass the relevant struct fields as > > pointers. > > > Maybe have GetYMM(unsigned num, YMM& reg)/SetYMM(unsigned num, const YMM > ®) methods on the XSAVE struct ? We aren't using XSAVE struct. We are using NetBSD-specific `struct xstate` that has guaranteed fixed offsets. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63545/new/ https://reviews.llvm.org/D63545 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
