labath added a comment.
We have the same XSTATE<->YMM conversion functions in NativeProcessLinux. It
would be nice to extract them to some common place (Plugins/Process/Utility, I
guess :P). The rest seems pretty straight-forward, though you're repeating the
patterns that I find really reduntant/annoying. Eg. I don't see the reason to
check the null-ness of the XState buffer. It sounds like it should be a hard
error for someone to call ReadXState without bothering to arrange for the
storage buffer to exist.
================
Comment at:
lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp:239
+
+ if (byte_order == lldb::eByteOrderBig) {
+ ::memcpy(m_xstate_x86_64.xs_fxsave.fx_xmm[reg_index].xmm_bytes,
----------------
Why would we ever want to do this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63545/new/
https://reviews.llvm.org/D63545
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
