clayborg added inline comments.
================
Comment at: source/Target/Target.cpp:1670
if (m_process_sp) {
- LanguageRuntime *runtime =
- m_process_sp->GetLanguageRuntime(lldb::eLanguageTypeObjC);
- if (runtime) {
- ObjCLanguageRuntime *objc_runtime = (ObjCLanguageRuntime *)runtime;
+ if (LanguageRuntime *objc_runtime =
+ m_process_sp->GetLanguageRuntime(lldb::eLanguageTypeObjC))
----------------
xiaobai wrote:
> xiaobai wrote:
> > clayborg wrote:
> > > labath wrote:
> > > > Same question about runtime iteration as in the other review.
> > > Seems like we should add a Process::SymbolsDidLoad() method that matches
> > > this method's signature and just call that. Process would iterate across
> > > all loaded language runtimes and call SymbolsDidLoad on any?
> > Right, we should definitely iterate over loaded language runtimes instead
> > of just using the ObjC runtime. Will update.
> Instead of adding `Process::SymbolsDidLoad`, I could instead iterate here
> over the loaded language runtimes with `Process::GetLanguageRuntimes` and
> call `LanguageRuntime::SymbolsDidLoad` on each one. What do you think? This
> would prevent us from having 3 classes with the method `SymbolsDidLoad` with
> the same signature.
That is fine as long as we iterate over all loaded language runtimes I am good.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62796/new/
https://reviews.llvm.org/D62796
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
