clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Seems like we need a Process::SymbolsDidLoad(...) function that we can call. It
should iterate over all loaded language runtimes (only loaded ones) and forward
the list.
================
Comment at: source/Target/Target.cpp:1670
if (m_process_sp) {
- LanguageRuntime *runtime =
- m_process_sp->GetLanguageRuntime(lldb::eLanguageTypeObjC);
- if (runtime) {
- ObjCLanguageRuntime *objc_runtime = (ObjCLanguageRuntime *)runtime;
+ if (LanguageRuntime *objc_runtime =
+ m_process_sp->GetLanguageRuntime(lldb::eLanguageTypeObjC))
----------------
labath wrote:
> Same question about runtime iteration as in the other review.
Seems like we should add a Process::SymbolsDidLoad() method that matches this
method's signature and just call that. Process would iterate across all loaded
language runtimes and call SymbolsDidLoad on any?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62796/new/
https://reviews.llvm.org/D62796
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
