teemperor added a comment. In D61440#1488424 <https://reviews.llvm.org/D61440#1488424>, @kwk wrote:
> In D61440#1488174 <https://reviews.llvm.org/D61440#1488174>, @teemperor wrote: > > > LGTM module some minor code style issues (You removed some `virtual`s but > > didn't fix the indentation of the parameters on the next line, see the > > inline comments for examples). > > > @teemperor I would have loved to use clang-format for this but apparently the > LLDB code is still manually formatted. It would be a bliss to just use the > LLVM clang-format style and never ever talk about "style" again. I assume you mean running clang-format manually on each file? If yes, then check out git-clang-format <https://github.com/llvm-mirror/clang/blob/master/tools/clang-format/git-clang-format> which works just fine in these situations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61440/new/ https://reviews.llvm.org/D61440 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
