teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM module some minor code style issues (You removed some `virtual`s but
didn't fix the indentation of the parameters on the next line, see the inline
comments for examples).
================
Comment at: lldb/include/lldb/Utility/Baton.h:67
+ void GetDescription(Stream *s,
lldb::DescriptionLevel level) const override {}
----------------
code style
================
Comment at: lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp:306
+ bool DoExecute(lldb::SBDebugger debugger, char **command,
+ lldb::SBCommandReturnObject &result) override {
----------------
code style
================
Comment at: lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp:351
+ bool DoExecute(lldb::SBDebugger debugger, char **command,
+ lldb::SBCommandReturnObject &result) override {
----------------
code style
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61440/new/
https://reviews.llvm.org/D61440
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
