teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land.
> So a long-term fix for this would require at least reworking ho that debug > information is generated. I believe the debug information correct but our lookup is just not finding/loading the necessary AST nodes? Otherwise I assume the radar is keeping track of the fact that this feature is broken, so LGTM so that we unblock the other reviews. ================ Comment at: packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py:9 # rdar://problem/48128064 - decorators.skipIfDarwin]) + decorators.skipIf]) ---------------- Nit pick: Isn't there a `skip` or so that's more expressive than `skipIf`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61266/new/ https://reviews.llvm.org/D61266 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits