shafik created this revision.
shafik added reviewers: jingham, aprantl, teemperor.
The `TestClassTemplateParameterPack.py` test does not work for the right
reasons. The expressions such as:
expression -- C<int, 16>().isSixteenThirtyTwo()
work only because we are currently pulling all the local variables e.g.:
using $__lldb_local_vars::argc;
using $__lldb_local_vars::argv;
using $__lldb_local_vars::myC;
using $__lldb_local_vars::myLesserC;
using $__lldb_local_vars::myD;
using $__lldb_local_vars::myLesserD;
regardless if we use them in the expression and this causes us to for example
to pull `C<int,16>` into the evaluation context but this is not how it should
work. Once we land: https://reviews.llvm.org/D46551
This will no longer work. When clang does the call back it is looking for `C`
but currently the debug information contains `C<int,16>` etc... So a long-term
fix for this would require at least reworking ho that debug information is
generated.
https://reviews.llvm.org/D61266
Files:
packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py
Index:
packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py
===================================================================
---
packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py
+++
packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py
@@ -6,4 +6,4 @@
decorators.expectedFailureAll(
compiler="gcc"),
# rdar://problem/48128064
- decorators.skipIfDarwin])
+ decorators.skipIf])
Index: packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py
===================================================================
--- packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py
+++ packages/Python/lldbsuite/test/lang/cpp/class-template-parameter-pack/TestClassTemplateParameterPack.py
@@ -6,4 +6,4 @@
decorators.expectedFailureAll(
compiler="gcc"),
# rdar://problem/48128064
- decorators.skipIfDarwin])
+ decorators.skipIf])
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
