labath added a comment.
Just an FYI: I was hitting llvm_unreachable in
Platform::GetSoftwareBreakpointTrapOpcode in this test. I fixed it in r357456
by specifying an explicit triple in the test. (I'm not sure how this wasn't hit
on the darwin bots.)
================
Comment at:
packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestWriteMemory.py:19-20
+ target = self.dbg.CreateTarget('')
+ if self.TraceOn():
+ self.runCmd("log enable gdb-remote packets")
+ process = self.connect(target)
----------------
jasonmolenda wrote:
> davide wrote:
> > I'm not sure you really need this, we can commit it if we need to debug.
> > Please note that the bots always run with `TraceOn() == True`.
> no big deal, but fwiw I put this sequence in every time I write a gdb remote
> client test - it's essential for debugging any problems with them. The
> amount of output is very small, it's not like a real debug session.
I think it would make sense to teach the general architecture of these tests (I
guess that would be the MockGDBServer class) to dump some additional info in
the `TraceOn()` case.
BTW, when running a test locally, you can pass `--channel "gdb-remote packets"`
to dotest to have it output the relevant logs to a file (the file will go to
the test traces directory).
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60022/new/
https://reviews.llvm.org/D60022
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
