JDevlieghere added a comment.

Thanks Ismail, the patch LGTM, assuming I understand the code correctly.

FWIW I think this function is a good example of how early returns might prevent 
something like this from happening in the future. If you agree and have the 
bandwidth, feel free to refactor it, either as part of this patch or as a 
separate patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60022/new/

https://reviews.llvm.org/D60022



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to