aprantl added a comment.
This looks mostly good now.
================
Comment at:
lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/basic/TestImportStdModule.py:19
+ @skipIf(oslist=no_match(["linux"]))
+ @skipIf(debug_info=no_match(["dwarf"]))
+ def test(self):
----------------
Do you understand why the "dwarf" is necessary?
================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ASTUtils.h:428
+ void getMemoryBufferSizes(MemoryBufferSizes &sizes) const override {
+ for (size_t i = 0; i < Sources.size(); ++i)
+ Sources[i]->getMemoryBufferSizes(sizes);
----------------
`std::for_each()` or `for (auto *S : Sources)`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58125/new/
https://reviews.llvm.org/D58125
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
