labath added inline comments.
================ Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:257 -CFLAGS += -I$(SRCDIR) -include $(THIS_FILE_DIR)test_common.h -I$(THIS_FILE_DIR) +ifndef NO_INC_DIRS + CFLAGS += -I$(SRCDIR) -include $(THIS_FILE_DIR)test_common.h -I$(THIS_FILE_DIR) ---------------- teemperor wrote: > labath wrote: > > I'm wondering why have you needed to do this (and whether we can figure out > > another solution to that). > Yeah I should have added this as a comment to the test. Our sysroot system > has only a few dummy headers, so we can resolve the `#include <sys/prctl.h>` > in `test_common.h`. The removed `-I` flags are actually unintentional, I'll > revert removing them. Ah, cool. I suspected something like that. In that case I suggest also renaming the flag to NO_TEST_COMMON_H or something. (We should probably replace the force-include by an actual include some day.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58125/new/ https://reviews.llvm.org/D58125 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
