[Lldb-commits] [PATCH] D58330: 01/03: new SectionPart for Section subranges (for effective .debug_types concatenation)

Tue, 19 Feb 2019 14:46:08 -0800 

clayborg added a comment.

So I question the need for the SectionPart class. Seems like it would be easier 
to just add extra args to the ReadSectionData calls? Comments?



================
Comment at: lldb/include/lldb/Symbol/ObjectFile.h:739
   // be larger than what Section::GetFileSize reports.
-  virtual size_t ReadSectionData(Section *section,
+  virtual size_t ReadSectionData(const SectionPart &section_part,
                                  DataExtractor &section_data);
----------------
Do we need a class here? Why not just add defaulted arguments?


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h:58-60
+namespace lldb_private {
+  class SectionPart;
+}
----------------
If we keep this class add it to lldb-forward.h and remove this


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58330/new/

https://reviews.llvm.org/D58330



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to