Ok, lgtm then On Wed, Jan 2, 2019 at 11:53 PM Pavel Labath <pa...@labath.sk> wrote:
> On 02/01/2019 18:32, Zachary Turner wrote: > > Just to be sure, this new test will fail without your Symtab changes > > right? I'm not in a state where I can look at code right now, and you > > say anything that symbolicates an address *can* use the symtab, but I > > don't know if you really meant *must* use the symtab. > > > > Yes, the test will fail without these changes. The reason I said "can" > is because symtab is one of the sources of symbolication (the other is > debug info for instance). However, in this case there is no other source > of symbol information, so this information "must" come from the symtab >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
