Just to be sure, this new test will fail without your Symtab changes right? I'm not in a state where I can look at code right now, and you say anything that symbolicates an address *can* use the symtab, but I don't know if you really meant *must* use the symtab.
On Wed, Jan 2, 2019 at 12:19 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath updated this revision to Diff 179819. > labath added a comment. > > Add some "image lookup" commands to the test. The test now goes through > lldb > instead of lldb-test, but I've kept the lldb-test changes, as I think they > make > sense regardless. The tricky part about the new test is the need to > specify the > "target symbols add" command via '-o', because I need lit to substitute > the full > path to the symbol file. > > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D56173/new/ > > https://reviews.llvm.org/D56173 > > Files: > lit/SymbolFile/Breakpad/Inputs/symtab.lldbinit > lit/SymbolFile/Breakpad/Inputs/symtab.syms > lit/SymbolFile/Breakpad/lit.local.cfg > lit/SymbolFile/Breakpad/symtab.yaml > source/API/SystemInitializerFull.cpp > source/Plugins/SymbolFile/Breakpad/CMakeLists.txt > source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp > source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h > source/Plugins/SymbolFile/CMakeLists.txt > source/Symbol/SymbolVendor.cpp > tools/lldb-test/SystemInitializerTest.cpp > tools/lldb-test/lldb-test.cpp > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
