tberghammer accepted this revision.
tberghammer added a comment.
LGTM
================
Comment at: include/lldb/Core/RangeMap.h:636
-template <typename B, typename S, typename T, unsigned N> class RangeDataArray
{
+template <typename B, typename S, typename T, unsigned N>
+class RangeDataVector {
----------------
Would it make sense to have a default value of 0 for N so people don't have to
specify it explicitly?
================
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.h:140
+ typedef lldb_private::RangeDataVector<lldb::addr_t, lldb::addr_t, FileRange,
+ 0>
VMRangeToFileOffset;
----------------
Should this be 1 to keep the previous semantics?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56170/new/
https://reviews.llvm.org/D56170
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
