labath marked an inline comment as done. labath added inline comments.
================ Comment at: unittests/Core/RangeMapTest.cpp:52-54 + // However, this does not always succeed. + // TODO: This should probably return the range (0, 40) as well. + EXPECT_THAT(Map.FindEntryThatContains(35), nullptr); ---------------- davide wrote: > I think this is a bug in the implementation. I agree. I think this can be fixed if we change the while loop in `FindEntryThatContains` to loop until the current range start address goes below the lookup address. If that's the behavior we want from this function, that is. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56170/new/ https://reviews.llvm.org/D56170 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
