On Thu, Nov 29, 2018 at 11:40 PM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote:
> labath added a comment. > > On 29/11/2018 21:29, Leonard Mosescu wrote: > > > Hi Aleksandr, yes, no objections to this patch. > > > > I was responding to Pavel's comments, which I also assume are > > forward-looking as well, not strictly related to this patch. > > Agreed, and I apologise for hijacking your review (I seem to be getting in > the habit of that). I initially thought that having a ObjectFilePDB might > mean that this patch would not be needed, but now I am slowly growing to > like it. I think it makes sense for a symbol file to be able to provide > additional symbols regardless of whether this could be done differently too. > Ok, there's no problem at all :) Thanks! -- Aleksandr Urakov Software Developer JetBrains http://www.jetbrains.com The Drive to Develop
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
