labath added a comment. On 29/11/2018 21:29, Leonard Mosescu wrote:
> Hi Aleksandr, yes, no objections to this patch. > > I was responding to Pavel's comments, which I also assume are > forward-looking as well, not strictly related to this patch. Agreed, and I apologise for hijacking your review (I seem to be getting in the habit of that). I initially thought that having a ObjectFilePDB might mean that this patch would not be needed, but now I am slowly growing to like it. I think it makes sense for a symbol file to be able to provide additional symbols regardless of whether this could be done differently too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53368/new/ https://reviews.llvm.org/D53368 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
