zturner added a comment. In https://reviews.llvm.org/D54216#1291453, @aleksandr.urakov wrote:
> Looks good, thank you! > > The only question is performance, haven't you checked how much time takes the > preprocessing on huge PDBs? Intuitively it seems that it shouldn't take too > much time (n*log(n) where n is the count of LF_NESTTYPE records), but may be > you have checked this? I checked on clang.pdb. For my local build of LLVM this about 780MB. It's quite slow in debug build (14 seconds for `ParseSectionContribs` and 60 seconds for `PreprocessTpiStream`), but in release build the combined total is less than 2 seconds for both function calls https://reviews.llvm.org/D54216 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
