clayborg added a comment. In https://reviews.llvm.org/D48393#1245342, @friss wrote:
> In https://reviews.llvm.org/D48393#1245049, @clayborg wrote: > > > In https://reviews.llvm.org/D48393#1244649, @labath wrote: > > > > > I agree with Greg that it would be best to restrict things such that > > > there is only one instance of parsing going on at any given time for a > > > single module. I think this was pretty much the state we reached when > > > this thread fizzled out the last time (there are some extra emails that > > > are not showing in phabricator history, the interesting ones start around > > > here: > > > http://lists.llvm.org/pipermail/lldb-commits/Week-of-Mon-20180618/041937.html). > > > I think the main part that needed to be resolved is whether we need to > > > go anything special when resolving debug info references *between* > > > modules (e.g. to prevent A/B deadlocks). > > > > > > We don't have to worry about references between modules as no module loads > > _ANY_ debug info from another module. > > > What about -gmodules? I don't remember where the module debug info is stored, > I think it is not shared so your statement would conceptually hold, but I'm > not sure anymore. We load the -gmodules DWARF and a stand alone file and then copy the AST types over into the AST for the SymbolFileDWARF that uses them. So we are good with -gmodules. https://reviews.llvm.org/D48393 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits