xiaobai added a comment. Can't speak much to the contents yet (Haven't done a thorough pass yet) but it looks like there's a lot of dead code you might want to remove. I commented on a few of them but there is probably more.
================ Comment at: packages/Python/lldbsuite/test/tools/lldb-vscode/variables/TestVSCode_variables.py:15 + +import pprint # TODO: REMOVE THIS PRIOR TO CHECKIN + ---------------- Should remove this ================ Comment at: packages/Python/lldbsuite/test/tools/lldb-vscode/variables/TestVSCode_variables.py:88 + source = 'main.cpp' + # source_path = os.path.join(os.getcwd(), source) + breakpoint1_line = line_number(source, '// breakpoint 1') ---------------- Commented out line ================ Comment at: packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py:82-86 + # try: + # return json.loads(json_str) + # except: + # dump_memory(0, json_str, 32, sys.stdout) + # sys.exit(1) ---------------- Dead code ================ Comment at: packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py:881 + if response['success']: + # dbg.request_setBreakpoints(source, [39]) + if options.sourceBreakpoints: ---------------- Dead code ================ Comment at: packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py:901-923 + # thread_infos = dbg.get_threads() + # for thread_info in thread_infos: + # tid = thread_info['id'] + # dbg.request_stackTrace(tid) + # dbg.request_stackTrace(stopped_events[0]['body']['threadId']) + # dbg.request_stackTrace(stopped_events[0]['body']['threadId'], + # startFrame=0) ---------------- Dead code https://reviews.llvm.org/D50365 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
