clayborg added inline comments.

================
Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:15
 // Other libraries and framework includes
+//#include "lldb/Core/Architecture.h"
 #include "lldb/Core/Module.h"
----------------
lemo wrote:
> it this set for removal?
Ah yes!


================
Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_ARM.cpp:196
+
+size_t RegisterContextMinidump_ARM::GetRegisterSetCount()  {
+  return k_num_reg_sets;
----------------
Not sure why. I was using the latest Xcode and got the warning. RegisterInfo is 
just a plain struct so it shouldn't cause any issues.


https://reviews.llvm.org/D49750



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to