sgraenitz marked an inline comment as done.
sgraenitz added inline comments.
================
Comment at: cmake/modules/LLDBConfig.cmake:417-423
+ option(LLDB_USE_BUILTIN_DEMANGLER "Use lldb's builtin demangler" OFF)
+ option(LLDB_USE_LLVM_DEMANGLER "Use llvm's new partial demangler" ON)
endif()
if(LLDB_USE_BUILTIN_DEMANGLER)
add_definitions(-DLLDB_USE_BUILTIN_DEMANGLER)
+elseif(LLDB_USE_LLVM_DEMANGLER)
+ add_definitions(-DLLDB_USE_LLVM_DEMANGLER)
----------------
labath wrote:
> Since these options are mutually exclusive it might be better to make this a
> single multi-valued setting. Also, this new demangler should also be
> available in the MSVC case, should it not? Yhe reason we have `if(MSVC)` here
> is because the "system" demangler is not available there, but that should not
> be an issue here.
> I am talking about cmake code here.
Sorry, just saw that too.
> Since these options are mutually exclusive it might be better to make this a
> single multi-valued setting.
The old `LLDB_USE_BUILTIN_DEMANGLER` might be removed entirely once we have
benchmark results. Otherwise I will make it multi-valued.
https://reviews.llvm.org/D49612
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
