Thank you a lot for explanations and commit! On Thu, Jul 19, 2018 at 4:40 PM Pavel Labath <lab...@google.com> wrote:
> Thanks. > > I agree you're not in the best position to make these kinds of changes > (and I don't think I would have asked you to do them). In fact, I was > already considering just changing that function myself, so I went > ahead and did that now in r337452. As far as I can tell, no tests need > to be updated as a result of this, though I haven't tried running the > test suite on non-linux platforms. > On Thu, 19 Jul 2018 at 12:49, Aleksandr Urakov > <aleksandr.ura...@jetbrains.com> wrote: > > > > On Thu, Jul 19, 2018 at 2:14 PM Pavel Labath <lab...@google.com> wrote: > >> > >> I knew I should have stayed quiet :P, but now that I am in, here's my > reasoning: > > > > Thank you for not staying quiet, I think it's the only way to have a > dialog and solve the problems :) > > > > I find your argumentation convincing. The problem is that I'm very new > in lldb, and I admit that my misgivings may be in vain. So I have no > objections if some more experienced lldb developer will commit this (I have > no commit access). Or, if you want that it to be exactly my patch, I can > make it (test it, find another such places etc.) some later, after current > work, and will send a review. > > > > What do you think about it? > -- Aleksandr Urakov Software Developer JetBrains http://www.jetbrains.com The Drive to Develop
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
