But can you, please, explain me why? Excuse me for so much fuss, I just wanted to explain my position... We have two cases now: - Just commit such a patch without an additional investigation. But it's not a good idea, because we can't be 100% sure that it is a typo (and even if it is, we still may break something from I listed above); - Make an additional investigation and commit this. But I think that it's unconstructive to do it now, because there are many problems with a higher priority. So I suggest to defer it for a better times. We may report a bug and assign it to me, I'll do it when I will finish other more important work.
What do you think about it? On Thu, Jul 19, 2018 at 12:13 PM Pavel Labath <lab...@google.com> wrote: > On Thu, 19 Jul 2018 at 10:04, Aleksandr Urakov via Phabricator > <revi...@reviews.llvm.org> wrote: > > So peoples who commited such spaces found them beautiful (or used the > approved formatting style, or used them for some special formatting cases), > > Or it's simply a typo. > > I don't want to make a bigger fuss of this than it already is, but I > think removing that space is a good idea. > -- Aleksandr Urakov Software Developer JetBrains http://www.jetbrains.com The Drive to Develop
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
