clayborg added a comment.

Would love to remove the "accept_zeroes" argument everywhere. Too much matching 
happens in LLDB and we can't have multiple shared libraries claiming zeros as 
their UUID



================
Comment at: include/lldb/Utility/UUID.h:54
+  void SetBytes(const void *uuid_bytes, uint32_t num_uuid_bytes,
+                bool accept_zeroes);
+  void SetBytes(llvm::ArrayRef<uint8_t> bytes, bool accept_zeroes);
----------------
I am not sure accept_zeroes is a good idea. LLDB does a lot of matching based 
on UUID and we can't have multiple shared libraries claiming to have zeroes as 
their UUID. It will cause chaos. Zeroes as a build ID is not very useful


https://reviews.llvm.org/D48479



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to