clayborg added a comment.
Looks good. Just a question about including the commented out default arguments
================
Comment at: source/API/SBThread.cpp:636
+void SBThread::StepOver(lldb::RunMode stop_other_threads
+ /* = lldb::eOnlyDuringStepping */) {
+ SBError error; // Ignored
----------------
might avoid showing the default argument in case it changes and we don't do
this anywhere else that I know of.
================
Comment at: source/API/SBThread.cpp:678
+void SBThread::StepInto(lldb::RunMode stop_other_threads
+ /* = lldb::eOnlyDuringStepping */) {
StepInto(NULL, stop_other_threads);
----------------
Ditto
================
Comment at: source/API/SBThread.cpp:684
+ lldb::RunMode stop_other_threads
+ /* = lldb::eOnlyDuringStepping*/) {
+ SBError error; // Ignored
----------------
Ditto
================
Comment at: source/API/SBThread.cpp:691
+ SBError &error, lldb::RunMode stop_other_threads
+ /* = lldb::eOnlyDuringStepping */) {
Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_API));
----------------
Ditto
https://reviews.llvm.org/D47991
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
