clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Remove the argument since we don't need it. Just assume we keep ".".
================
Comment at: include/lldb/Utility/FileSpec.h:535
- void RemoveLastPathComponent();
+ void RemoveLastPathComponent(bool keep_dot = false);
----------------
Why add this? If the path is just "." to begin with, there is nothing to do. I
would vote to not add this argument since we don't need it. Add it back if we
ever do.
================
Comment at: source/Host/macosx/Symbols.cpp:412-415
+ build_path.RemoveLastPathComponent(true);
+ build_path.RemoveLastPathComponent(true);
+ source_path.RemoveLastPathComponent(true);
+ source_path.RemoveLastPathComponent(true);
----------------
revert
================
Comment at: source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp:263-266
+ build_path.RemoveLastPathComponent(true);
+ build_path.RemoveLastPathComponent(true);
+ source_path.RemoveLastPathComponent(true);
+ source_path.RemoveLastPathComponent(true);
----------------
revert
================
Comment at: source/Utility/FileSpec.cpp:788
-void FileSpec::RemoveLastPathComponent() {
+void FileSpec::RemoveLastPathComponent(bool keep_dot) {
// CLEANUP: Use StringRef for string handling.
----------------
Remove arg.
https://reviews.llvm.org/D47495
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
