jasonmolenda added a comment.

This looks good.  My original change in r311622 to add this "remove the last 
two file path components" should have explicitly said that this is only done 
for DBGVersion == 2 to make it clearer for people reading the code.

At this point the parsing code behaves like:

DBGVersion 1 (or missing DBGVersion) - ignore the DBGSourcePathRemapping 
dictionary
DBGVersion 2 - Use DBGSourcePathRemapping, but chop off two components from 
both source and destination (assumption: the last two components are 
PROJECT-NAME/PROJECT-VERSION-NUMBER)
DBGVersion 3 - Use DBGSourcePathRemapping without any modifications

These interpretations of the DBGSourcePathRemapping / DBGVersion have been a 
little ad-hoc, as we've discovered issues in deployed plists that needed to be 
accommodated by lldb.


https://reviews.llvm.org/D47495



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to