clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land.
Only question is if we remove the extra empty scope as noted in inline comments. Looks good. ================ Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:86 // Keep a flat array of the DIE for binary lookup by DIE offset - if (!cu_die_only) { + { Log *log( ---------------- Do we need this empty scope? Remove? https://reviews.llvm.org/D46810 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits