labath added inline comments.
Herald added a subscriber: arphaman.

================
Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:179
+  if (!m_die_array.empty()) {
+    lldbassert(!m_first_die || m_first_die == m_die_array.front());
+    m_first_die = m_die_array.front();
----------------
xbolva00 wrote:
> xbolva00 wrote:
> > @jankratochvil is this correct assert? Our downstream lldb based on lldb 7 
> > with our custom targets hits this assert.  If we remove it, we see no 
> > obvious breakages.
> cc @labath 
I agree with Jan. The two dies should be the same. The fact that they aren't 
probably means there is a bug somewhere. It would be good to know how the two 
dies differ and what is the input dwarf they are generated from.


Repository:
  rL LLVM

https://reviews.llvm.org/D46810



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to