labath added inline comments.
================ Comment at: lit/tools/lldb-mi/breakpoint/break-insert.test:10 +-file-exec-and-symbols a.out +# CHECK-AFTER: ^done + ---------------- polyakov.alex wrote: > labath wrote: > > I'm not familiar with this directive. Are you sure that this actually does > > anything? > I tried to use only CHECK directive, but got errors like pattern not found, > so I decided that it may be caused due to CHECK search features, for example, > as I know, it finds pattern from the start of the file. If we want to check > lldb-mi output, we should follow a specific order. > > In our case, we should find "^done" string directly after -break-insert > command's output. I think you got the FileCheck operation wrong. a `CHECK` should always start matching from the previous match. The reason that this is passing for you now is that CHECK-AFTER is a non-existing directive and FileCheck ignores it (try replacing it with a bogus string and see if it still passes). if `CHECK` is not working for you here then you probably have the pattern wrong. Repository: rL LLVM https://reviews.llvm.org/D46588 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
