zturner added inline comments.
================
Comment at: source/Core/ArchSpec.cpp:890
+bool ArchSpec::ContainsOnlyArch(const llvm::Triple &triple) {
+ return triple.getOSName().empty() &&
+ triple.getVendorName().empty() &&
----------------
Should you also add `!triple.getArchName().empty()` to the condition? Also,
perhaps name this parameter `normalized_triple` to document the expectation to
the caller.
https://reviews.llvm.org/D39387
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
