haven't had a chance to look at the patch yet, but just to comment on one part from Zach:
> On Oct 27, 2017, at 2:06 PM, Zachary Turner via Phabricator via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > > ================ > Comment at: source/Target/Platform.cpp:986-991 > + if (normalized_triple.getVendorName().empty()) > + normalized_triple.setVendor(compatible_triple.getVendor()); > + if (normalized_triple.getOSName().empty()) > + normalized_triple.setOS(compatible_triple.getOS()); > + if (normalized_triple.getEnvironmentName().empty()) > + normalized_triple.setEnvironment(compatible_triple.getEnvironment()); > ---------------- > Are these cases even possible? Why would the vendor and os ever be empty? I > thought only the environment could be empty. > This can happen when connecting to a bare board / low level firmware development. You may only know armv7em-*-*. > > https://reviews.llvm.org/D39387 > _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
