On Wed, Sep 20, 2017 at 10:46 AM Jim Ingham <jing...@apple.com> wrote:
> Directly WRT testing. I’m not against ALSO adding gtests when you add > some functionality. But when your change is actually adding behaviors to > lldb, one of the things you need to ask yourself is if this is > functionality that extension developers for lldb will benefit from. If it > is, then adding affordances in the SB API should be considered an essential > part of a complete implementation of the feature. And I assert from > experience that writing tests for that feature at the SB API layer is a > really good way to ensure that the API’s you add make sense and actually > get at the things you intended to make available. > I also assert from experience that unfortunately it's also a good way to make sure that the test doesn't get written in the first place :(
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
