clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Looks fine, just add an error that checks that when the --file options is used,
that only one argument (symbol file) is specified.
================
Comment at: source/Commands/CommandObjectTarget.cpp:4302-4305
+ if (file_option_set) {
+ module_spec.GetFileSpec() =
+ m_file_option.GetOptionValue().GetCurrentValue();
+ }
----------------
We should verify that if the file option is set, then there is only one symbol
file argument as it wouldn't make sense to do:
```
(lldb) target symbols add -- file a.out a.out.symbols b.out.symbols
```
https://reviews.llvm.org/D35607
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits