jasonmolenda wrote:

The general discussion of how to test this class of change is interesting, but 
I don't want to lose sight of the fact that this PR will not work.  It does 
nothing but break existing functionality for RISC-V users (disabling 
instruction emulation used to do instruction stepping).  It's not just a matter 
of how to automated test; it was not tested while it was being developed 
at-desk, let alone in CI.  There's nothing here, currently, to test.

https://github.com/llvm/llvm-project/pull/147434
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to