================
@@ -31,6 +34,122 @@ static DWORD
ToTimeout(std::optional<MainLoopWindows::TimePoint> point) {
return ceil<milliseconds>(dur).count();
}
+namespace {
+
+class PipeEvent : public MainLoopWindows::IOEvent {
+public:
+ explicit PipeEvent(HANDLE handle)
+ : IOEvent((IOObject::WaitableHandle)CreateEventW(
+ NULL, /*bManualReset=*/FALSE,
+ /*bInitialState=*/FALSE, NULL)),
+ m_handle(handle), m_ready(CreateEventW(NULL, /*bManualReset=*/FALSE,
+ /*bInitialState=*/FALSE, NULL))
{
+ assert(event && ready);
+ }
+
+ ~PipeEvent() override {
+ if (m_monitor_thread.joinable()) {
+ m_stopped = true;
+ SetEvent(m_ready);
+ // Keep trying to cancel ReadFile() until the thread exits.
+ do {
+ CancelIoEx((HANDLE)m_handle, /*lpOverlapped=*/NULL);
+ } while (WaitForSingleObject(m_monitor_thread.native_handle(), 1) ==
+ WAIT_TIMEOUT);
+ m_monitor_thread.join();
+ }
+ CloseHandle((HANDLE)m_event);
+ CloseHandle(m_ready);
+ }
+
+ void WillPoll() override {
+ if (!m_monitor_thread.joinable())
----------------
labath wrote:
What would you say to creating the thread in the constructor? It would remove
the `joinable()` calls, and thing that adding a pipe to the loop is quickly
followed by a poll operation anyway.
https://github.com/llvm/llvm-project/pull/145621
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
