https://github.com/labath commented:

It's better, but it still looks like there's an inlined copy of 
ParseIdExpression inside ParsePrimaryExpression. I'd be nice to avoid that as 
it's easy to forget the inlined version when updating ParseIdExpression (and 
the problem would show up on variables inside anonymous namespaces).

Maybe that's impossible, but if so, I'd like to know why.

https://github.com/llvm/llvm-project/pull/145055
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to