cmtice wrote:

> If the test you found the anonymous namespace issue it is explicitly testing 
> the handling of anonymous namespaces, then this is fine. However, if it's 
> doing that as a side-effect of testing something else, then it may be nice to 
> have an explicit test case for it. (Particularly as the anonymous namespace 
> thing can appear in other positions as well (`ns1::(anonymous 
> namespace)::foo`, `(anonymous namespace)::ns::(anonymous namespace)::foo`, 
> etc.)

The test I found is lldb-api :: lang/cpp/namespace/TestNamespace.py, which does 
a basic test of '(anonymous namespace)' at the start of a variable name, but 
not embedded in the variable name.  I agree that we should test it in other 
positions as well. I will add that to one of the DIL tests.

https://github.com/llvm/llvm-project/pull/145055
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to