adrian-prantl wrote: > I'm not sure I understand the need for the separate class. What's present in > the `XcodeSDK` class that prevents you from using it on PlatformWindows? > Given that the current class is part of Utility, it shouldn't depend on > anything Darwin specific. If we need to make this class behave differently > depending on the platform, then maybe it's time to make this a generic "SDK" > plugin with different implementations depending on the platform?
I suggested this change. My thinking was that we should separate out an SDK _specification_ from a resolved local SDK and that it would clarify APIs if the two were separate types, so we know if we deal with a resolved absolute path, or abstract specification like "any iOS 18.5 SDK". https://github.com/llvm/llvm-project/pull/144396 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
