https://github.com/labath commented:
The code seems okay. I don't know anything about the format, so I don't know which parts are "obvious" and which not, but I'd encourage you to add comments where you think it might be useful. You're right that lldb-test doesn't dump symbols. You should be able to test these changes with something like `lldb %t -o "image dump symtab"`, but if you find that is missing some crucial piece of information, it would also be fine to extend lldb-test to dump the data you need. https://github.com/llvm/llvm-project/pull/141577 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
